Feature/hw 04 - #4
Open
uoles wants to merge 27 commits into
Open
Conversation
- Добавление исключения QuestionsFileLoadingException. - Работа с консолью вынесена в сервис ConsoleService. - Тесты для QuestionsDAO.
- Добавлены тесты.
- Изменения в структуре файлов.
- Использование библиотеки lombok.
- Файл настроек. - Java + Annotation-based конфигурация.
- Добавление своего баннера.
stvort
approved these changes
May 25, 2019
| consoleService.write(c_delimeter); | ||
| } | ||
|
|
||
| long count = questions.stream() |
There was a problem hiding this comment.
Функционал по печати результатов лучше вынести в отдельный метод
| } | ||
|
|
||
| @ShellMethod(key = { "startTest" }, value = "Start test") | ||
| public void startTest() { |
There was a problem hiding this comment.
Если разделить processor.startTest(); Хотя бы на регистрацию и начало теста, то появится замечательная возможность попробовать обеспечить очередность команд с помощью @ShellMethodAvailability
| @SpringBootConfiguration | ||
| @ComponentScan(basePackages = "ru.otus.mkulikov.app") | ||
| @EnableConfigurationProperties | ||
| public class AppTestConfig { |
There was a problem hiding this comment.
Кстати команды шелл тоже можно тестировать. Для этого можно внедрить в тест @Autowired Shell shell; и далее shell.evaluate(() -> "startTest");
- Разделение функционала метода startTest и использование @ShellMethodAvailability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.